Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds psalm static analysis #8

Merged
merged 2 commits into from
Jan 3, 2022
Merged

Adds psalm static analysis #8

merged 2 commits into from
Jan 3, 2022

Conversation

gsteel
Copy link
Member

@gsteel gsteel commented Jan 3, 2022

No description provided.

@codecov
Copy link

codecov bot commented Jan 3, 2022

Codecov Report

Merging #8 (c5d28a0) into main (8b182f7) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##                main        #8   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity        13        15    +2     
===========================================
  Files              6         6           
  Lines             34        39    +5     
===========================================
+ Hits              34        39    +5     
Impacted Files Coverage Δ
src/ConfigProvider.php 100.00% <ø> (ø)
src/AdminClientFactory.php 100.00% <100.00%> (ø)
src/BaseFactory.php 100.00% <100.00%> (ø)
src/ClientFactory.php 100.00% <100.00%> (ø)
src/Exception/MissingAccountKey.php 100.00% <100.00%> (ø)
src/Exception/MissingServerKey.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b182f7...c5d28a0. Read the comment docs.

Copy link
Member Author

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the abstract factory constructor is now marked final and the concrete factory classes are also final, this is effectively a BC break

@gsteel gsteel merged commit aa2239a into main Jan 3, 2022
@gsteel gsteel deleted the psalm branch January 3, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant