Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NGSTACK-461: in Site API v4 visible is true by default #53

Merged
merged 2 commits into from
Nov 17, 2020

Conversation

pspanja
Copy link
Member

@pspanja pspanja commented Nov 17, 2020

Two minor improvements:

  • removed visible condition as it's true by default in Site API v4+
  • moved match block to the end of the view rule

@pspanja pspanja requested a review from emodric November 17, 2020 07:05
@emodric emodric merged commit 8705c68 into master Nov 17, 2020
@emodric
Copy link
Member

emodric commented Nov 17, 2020

Thanks @pspanja !

@emodric emodric deleted the NGSTACK-461_visible_default branch November 17, 2020 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants