Add Deploy on Paltform.sh button #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this repo already has Platform.sh configuration files in it (inherited from Ibexa), here's a button to quick-launch on Platform.sh. I added it where it seemed to make sense in context, but feel free to move it. The UTM tags are just so we can keep track of which deploy button is which. Let me know if you've any questions.
|
Hi! Thanks for the PR! You're right, this repo is indeed inherited from Ibexa/eZ Platform. Changes from upstream are also regulary merged here, so maybe it would be better to create a PR there, and we will pick this up when merging, making sure that the link is still valid for this repo (and all UTM params). What do you think? If for some reason Ibexa doesn't think it's acceptable, I will merge it here then! |
|
I've reached out to them, but they don't seem interested. I'd say let's go ahead and merge this one. |
|
Still interested in this link? Can we get a merge? 😃 |
|
Thanks @Crell ! |
|
Sorry for the delay, btw! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this repo already has Platform.sh configuration files in it (inherited from Ibexa), here's a button to quick-launch on Platform.sh. I added it where it seemed to make sense in context, but feel free to move it. The UTM tags are just so we can keep track of which deploy button is which.
Let me know if you've any questions.