Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NGSTACK-476 - Add logic for with_intro on listitem_with_intro templates #47

Merged
merged 1 commit into from
Nov 2, 2020
Merged

NGSTACK-476 - Add logic for with_intro on listitem_with_intro templates #47

merged 1 commit into from
Nov 2, 2020

Conversation

Ljudevit
Copy link
Member

Until now, only fallback listitem template had a logic with with_intro parameter to display the intro.

All specific templates did not have this, so this PR enables this to make it work.

@Ljudevit Ljudevit requested a review from emodric October 30, 2020 18:22
@Ljudevit Ljudevit changed the base branch from master to 1.9 October 30, 2020 18:22
@Ljudevit Ljudevit requested a review from hknezevic October 30, 2020 18:23
@emodric emodric merged commit ca4e1eb into 1.9 Nov 2, 2020
@emodric emodric deleted the NGSTACK-476 branch November 2, 2020 14:06
@emodric
Copy link
Member

emodric commented Nov 2, 2020

Thanks @Ljudevit !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emodric emodric Awaiting requested review from emodric

@hknezevic hknezevic Awaiting requested review from hknezevic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ljudevit @emodric