Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NGSTACK 450 - eliminate precontent block and template cleanup for unnecessary markup #41

Merged
merged 3 commits into from
Oct 22, 2020
Merged

NGSTACK 450 - eliminate precontent block and template cleanup for unnecessary markup #41

merged 3 commits into from
Oct 22, 2020

Conversation

zulicek
Copy link
Contributor

@zulicek zulicek commented Oct 19, 2020

I eliminated precontent block in standard full views, necessary changes in layouts are:

Deafult Layout

  • delete pre_content block
  • disable option "Wrap in container"
  • remove vertical whitespace on top, leaving only medium whitespace on bottom

@zulicek zulicek requested review from emodric and Ljudevit October 19, 2020 11:01
@zulicek zulicek changed the title Ngstack 450 NGSTACK 450 - eliminate precontent block Oct 19, 2020
@zulicek zulicek changed the title NGSTACK 450 - eliminate precontent block NGSTACK 450 - eliminate precontent block and template cleanup for unnecessary markup Oct 22, 2020
@emodric emodric merged commit 84df41d into 1.9 Oct 22, 2020
@emodric
Copy link
Member

emodric commented Oct 22, 2020

Thank you @zulicek !

@emodric emodric deleted the NGSTACK-450 branch October 22, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emodric emodric Awaiting requested review from emodric

@Ljudevit Ljudevit Awaiting requested review from Ljudevit

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zulicek @emodric @pspanja