Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NGSTACK-458 #39

Merged
merged 3 commits into from
Oct 20, 2020
Merged

NGSTACK-458 #39

merged 3 commits into from
Oct 20, 2020

Conversation

hknezevic
Copy link
Member

  • change the base Symfony form theme we are extending in the custom form theme from "form_div_layout" to "bootstrap_4_layout". We are using bootstrap 4 in the current website frontend.
  • this also solves the visual/markup problem with rendering certain Symfony form fields on the frontend (checkboxes, radio buttons, date and date/time)
  • remove form-control CSS class from all form_row elements, it is now added through the theme
  • apply custom form theme in all templates where we render Symfony forms.

@emodric emodric merged commit 93fa4c0 into 1.9 Oct 20, 2020
@emodric emodric deleted the NGSTACK-458 branch October 20, 2020 08:46
@emodric
Copy link
Member

emodric commented Oct 20, 2020

Thanks @hknezevic !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants