NGSTACK-448 Implement active state on main menu via JS #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hknezevic
changed the title
emodric
reviewed
Oct 20, 2020
emodric
reviewed
Oct 20, 2020
src/AppBundle/Resources/views/themes/app/pagelayout_variables.html.twig
Outdated
Show resolved
Hide resolved
emodric
reviewed
Oct 20, 2020
src/AppBundle/Resources/views/themes/app/pagelayout_variables.html.twig
Outdated
Show resolved
Hide resolved
emodric
reviewed
Oct 20, 2020
… into data-path variable on top page div
…, add data-location-id parameter on the menu items
…ering menus, we will not vary the ESI fragment by active item ID anymore
hknezevic
force-pushed
the
NGSTACK-448
branch
from
3494dec to
8c50624
Compare
…es; just check location not empty in pagelayout; remove raw
…ck, to make clear what changes were applied compared to the original
hknezevic
commented
Nov 9, 2020
| @@ -32,7 +32,7 @@ | |||
|
|
|||
| {% include '@NetgenSite/parts/facebook_api.html.twig' %} | |||
|
|
|||
| <div id="page"{% if page_css_class|default is not empty %} class="{{ page_css_class }}"{% endif %}> | |||
| <div id="page"{% if page_css_class|default is not empty %} class="{{ page_css_class }}"{% endif %}{% if location is defined and location is not empty %} data-path='["{{ location.path|join('","') }}"]'{% endif %}> | |||
There was a problem hiding this comment.
@emodric I have completely remove the code block from the pagelayout_variables.html.twig. I am only doing the check for the location object here (exists and not empty) so it doesn't crash on module pages like search or tag view. Raw was removed as well as the slicing of the system root node.
|
Thanks @hknezevic ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement active state on main menu via JS