Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add section to devconfig #953

Merged
merged 10 commits into from
May 27, 2024
Merged

Add section to devconfig #953

merged 10 commits into from
May 27, 2024

Conversation

ddutt
Copy link
Member

@ddutt ddutt commented May 27, 2024

Description

Added support for searching for section or line by regex in device config

Type of change

  • New feature (non-breaking change which adds functionality)

New Behavior

Users can now search device config's by section or a specific line to see if it exists in the running config of a device.
...

Contrast to Current Behavior

Users cannot search inside device config with existing code.

...

Discussion: Benefits and Drawbacks

Users have often requested the ability to search insde configs for specific lines or sections. This commit enables that now.

Changes to the Documentation

...

Proposed Release Note Entry

Added support for searching for a line or section within a device config via the section keyword. The specification can be a simple string or regex.

Double Check

  • I have read the comments and followed the CONTRIBUTING.md.
  • I have explained my PR according to the information in the comments or in a linked issue.
  • My PR source branch is created from the develop branch.
  • My PR targets the develop branch.
  • All my commits have --signoff applied

ddutt added 2 commits May 26, 2024 22:15
Signed-off-by: Dinesh Dutt <dd.ps4u@gmail.com>
Signed-off-by: Dinesh Dutt <dd.ps4u@gmail.com>
ddutt added 4 commits May 26, 2024 22:44
Signed-off-by: Dinesh Dutt <dd.ps4u@gmail.com>
Signed-off-by: Dinesh Dutt <dd.ps4u@gmail.com>
Signed-off-by: Dinesh Dutt <dd.ps4u@gmail.com>
Signed-off-by: Dinesh Dutt <dd.ps4u@gmail.com>
@ddutt ddutt force-pushed the add-section-to-devconfig branch from bf8d302 to 6ae4848 Compare May 27, 2024 05:44
ddutt and others added 4 commits May 26, 2024 23:47
Signed-off-by: Dinesh Dutt <dd.ps4u@gmail.com>
Signed-off-by: Dinesh Dutt <dd.ps4u@gmail.com>
Signed-off-by: LucaNicosia <luca.nicosia@stardustsystems.net>
Signed-off-by: LucaNicosia <luca.nicosia@stardustsystems.net>
@ddutt ddutt merged commit 0c5e593 into develop May 27, 2024
13 checks passed
@ddutt ddutt deleted the add-section-to-devconfig branch May 27, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants