Add section to devconfig #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dinesh Dutt <dd.ps4u@gmail.com>
Signed-off-by: Dinesh Dutt <dd.ps4u@gmail.com>
Signed-off-by: Dinesh Dutt <dd.ps4u@gmail.com>
Signed-off-by: Dinesh Dutt <dd.ps4u@gmail.com>
Signed-off-by: Dinesh Dutt <dd.ps4u@gmail.com>
Signed-off-by: Dinesh Dutt <dd.ps4u@gmail.com>
ddutt
force-pushed
the
add-section-to-devconfig
branch
from
bf8d302
to
6ae4848
Compare
claudious96
approved these changes
May 27, 2024
Signed-off-by: Dinesh Dutt <dd.ps4u@gmail.com>
Signed-off-by: Dinesh Dutt <dd.ps4u@gmail.com>
Signed-off-by: LucaNicosia <luca.nicosia@stardustsystems.net>
Signed-off-by: LucaNicosia <luca.nicosia@stardustsystems.net>
LucaNicosia
force-pushed
the
add-section-to-devconfig
branch
from
8a9ed12
to
4aa1c81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for searching for section or line by regex in device config
Type of change
New Behavior
Users can now search device config's by section or a specific line to see if it exists in the running config of a device.
...
Contrast to Current Behavior
Users cannot search inside device config with existing code.
...
Discussion: Benefits and Drawbacks
Users have often requested the ability to search insde configs for specific lines or sections. This commit enables that now.
Changes to the Documentation
...
Proposed Release Note Entry
Added support for searching for a line or section within a device config via the section keyword. The specification can be a simple string or regex.
Double Check
developbranch.developbranch.--signoffapplied