Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vcenter as inventory source #939

Merged
merged 4 commits into from
Sep 2, 2024
Merged

Conversation

tgupta3
Copy link
Contributor

@tgupta3 tgupta3 commented May 11, 2024

Related Issue

issue #928

Description

Add vcenter support to suzieq. This will fetch the relevant VMs and their IPs that can be used to collect required data. The VM should have a custom attribute key (default is suzieq), the value of the key doesn't matter, in order for it to be part of the inventory.

Dependency added - pyvnomi

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

New Behavior

A new vcenter source can be added like this

sources:
- name: vsphere-devices
  type: vcenter
  url: https://<url_vcenter>
  username: <trim>
  password: plain:<trim>
  ssl-verify: False
  attributes:
    - "monitored"

Discussion: Benefits and Drawbacks

Vmware is commonly used in on-prem. This would allow monitoring of linux devices without specifying the devices individually. The change is backwards compatible.

Proposed Release Note Entry

Add vcenter source for inventory.

Double Check

  • [ x] I have read the comments and followed the CONTRIBUTING.md.
  • [ x] I have explained my PR according to the information in the comments or in a linked issue.
  • [ x] My PR source branch is created from the develop branch.
  • [ x] My PR targets the develop branch.
  • [ x] All my commits have --signoff applied

@tgupta3 tgupta3 force-pushed the vcenter-inventory branch 4 times, most recently from 8bc79eb to 905aeed Compare May 11, 2024 02:44
@ddutt
Copy link
Member

ddutt commented Jun 3, 2024

@tgupta3 Can you please rebase to latest deveop?

Signed-off-by: Tushar <tgupta3@users.noreply.github.com>
Signed-off-by: Tushar <tgupta3@users.noreply.github.com>
Signed-off-by: Tushar <tgupta3@users.noreply.github.com>
Signed-off-by: Tushar <tgupta3@users.noreply.github.com>
@tgupta3
Copy link
Contributor Author

tgupta3 commented Jun 3, 2024

@tgupta3 Can you please rebase to latest deveop?

Done

@ddutt ddutt merged commit e31484a into netenglabs:develop Sep 2, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants