Alerta.io notification improvements #4576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use 'indeterminate' severity as catch-all * move $family to "resource" * set "service" to 'Netdata' not $host * set "group" to "Performance' * set "value" to $value_sting not $alarm * add $alarm_id as a "tag" * add $roles, $name, $chart, $familty and $src as "attributes" * don't set auth header unless $ALERTA_API_KEY is set * log suppressed alerts (202 Accepted) as info not error * use $chart as resource for httpcheck alarms
|
|
|
I think this PR is good! Nice work @satterly ! Thank you! |
|
@ktsaou I'll try to get it tested at some point later today. From a quick look over the Alerta.io documentation though, the changes appear to be correct as far as I can tell. |
|
@Ferroin thank you! |
|
OK, finally got this tested. It appears here to be working as advertised. |
Ferroin
approved these changes
Nov 8, 2018
kiku-jw
pushed a commit
to kiku-jw/netdata
that referenced
this pull request
Mar 4, 2019
* Enhance support of Alerta notifications * use 'indeterminate' severity as catch-all * move $family to "resource" * set "service" to 'Netdata' not $host * set "group" to "Performance' * set "value" to $value_sting not $alarm * add $alarm_id as a "tag" * add $roles, $name, $chart, $familty and $src as "attributes" * don't set auth header unless $ALERTA_API_KEY is set * log suppressed alerts (202 Accepted) as info not error * use $chart as resource for httpcheck alarms * Update alerta wiki page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance support of Alerta notifications …
Update and simplify the wiki page for alerta.
/cc @kattunga