Merge pull request #105 from saskodh/valdrMessage-memleak

Fixed potential memory leaks
netceteragroup · Apr 13, 2016 · ec235ce · ec235ce
2 parents 05e5872 + 9c0963b
commit ec235ce
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 3 deletions.
diff --git a/src/core/valdrFormGroup-directive.js b/src/core/valdrFormGroup-directive.js
@@ -98,12 +98,15 @@ var valdrFormGroupDirectiveDefinition =
         };
 
         this.removeMessageElement = function (ngModelController) {
-          messageElements[ngModelController.$name].remove();
+          if (messageElements[ngModelController.$name]) {
+            messageElements[ngModelController.$name].remove();
+            delete messageElements[ngModelController.$name];
+          }
         };
 
       }]
     };
   }];
 
 angular.module('valdr')
-  .directive('valdrFormGroup', valdrFormGroupDirectiveDefinition);
+  .directive('valdrFormGroup', valdrFormGroupDirectiveDefinition);
diff --git a/src/message/valdrMessage-directive.js b/src/message/valdrMessage-directive.js
@@ -141,9 +141,13 @@ angular.module('valdr')
           }
         }, true);
 
-        $rootScope.$on('$translateChangeSuccess', function () {
+        var unregisterTranslateChangeHandler = $rootScope.$on('$translateChangeSuccess', function () {
           updateTranslations();
         });
+
+        scope.$on('$destroy', function () {
+          unregisterTranslateChangeHandler();
+        });
       }
     };
   }]);
diff --git a/src/message/valdrMessage-directive.spec.js b/src/message/valdrMessage-directive.spec.js
@@ -342,6 +342,21 @@ describe('valdrMessage directive with angular-translate', function () {
     expect(element.find('span').html()).toBe('field: Field Name param: 3 secondParam: 4');
   });
 
+  it('should unregister translate change handler on destroy to avoid potential memory leaks', function () {
+    // given
+    var element = compileTemplate();
+    spyOn(valdrMessage, '$translate').andReturn({ then: function () {} });
+    $scope.$destroy();
+    element.remove();
+
+    // when
+    $translate.use('de');
+    $scope.$digest();
+
+    // then
+    expect(valdrMessage.$translate).not.toHaveBeenCalled();
+  });
+
 });
 
 describe('valdrMessage directive with angular-translate and valdrFieldNameKeyGenerator', function () {