-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce Histogram Cardinality #595
Conversation
PR Explanation: Problem: Current Histogram implementation has a high cardinality due the way that datapoints are calculated. Moreover, the different datapoints almost every bucket do not allow to proper plot histogram over time. Solutions: First attempt: Use Opentelemetry Exponential Histogram - after investigating it, notice that there is no way to map exponential histogram to prometheus structure.. It is not supported by prometheus and it would not be good to do a implementation exclusively to Opentelemetry (without support to prometheus and json). This PR attempt: Prometheus histogram high cardinality problem seems to be a common issue in the community. One custom implementation to that is provided by VictoriaMetrics
It can be found in this article https://valyala.medium.com/improving-histogram-usability-for-prometheus-and-grafana-bc7e5df0e350 I've adapted the solution for our datasketches approach |
Interesting - seems like a good goal, my only concern is whether we know that existing data/graphs won't change in a significant way if this rolls out? I see you had to change the test to remove some answers, for example |
Histogram Metric is only used yet by Netprobe Handler and both feature(Histogram and Netprobe) were released (4.2.0) as BETA:
|
No description provided.