-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/update pcapplusplus version #224
Conversation
Basically, I performed 4 changes:
Updates required by newer version of pcapplusplus:
|
src/inputs/pcap/PcapInputStream.cpp
Outdated
@@ -172,7 +172,7 @@ void PcapInputStream::start() | |||
currInterface = currInterface->next; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so now that we have clone(), we want to remove this whole block and avoid calling libpcap functions directly. all we have to do now is set _pcapDevice (from block on 144) to pcapDevice->clone()
if (_pcapDevice == nullptr) { | ||
throw PcapException(fmt::format("Couldn't find interface by provided name: \"{}\". Available interfaces: {}", TARGET, ifNameList)); | ||
} | ||
// end upstream PcapPlusPlus incompatibility block |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@weyrick this is right now?
No description provided.