Fixes #164 (partially) - Add region field to site #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremystretch
added
the
status: accepted
|
It's a good start, but there's a lot more work needed to implement a new model. We need views for creating, editing, and deleting objects, as well as API serializers and endpoints. |
jeremystretch
added
pr/hold
and removed
status: accepted
|
Sorry I didn't understand, do you mean region should be a new model and not only a field ? |
|
Yes, we would need to define a Region model (similar to the Site model) as well as the views, forms, and API mechanisms for it. |
|
Okay, I'm doing that. Should site-to-region linking be mandatory ? |
|
No, any new relationships being added to the NetBox data model must be optional. |
|
Closing due to inactivity |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. I added a charfield "region" in model Site. It allows to distinguish, for instance, sites in different cities. That was asked in issue #164 .