Closes #18023: Employ register_model_view() for list views
#18029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bctiemann
reviewed
Nov 20, 2024
| @@ -1,89 +1,39 @@ | |||
| from django.urls import include, path | |||
|
|
|||
| from utilities.urls import get_model_urls | |||
| from . import views | |||
| from . import views # noqa F401 | |||
There was a problem hiding this comment.
I do feel like these ought to be avoided, if just because they make things less clear.
There was a problem hiding this comment.
Agreed, but we need to import the views somehow. If not here, we could do it under the ready() method for each app.
bctiemann
approved these changes
Nov 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #18023
register_model_view()andget_model_urls()to support list viewsregister_model_view()as we do currently for detail views