Closes #17733: Replace pycodestyle with ruff
#17734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthanson
reviewed
Oct 10, 2024
| @@ -50,4 +50,4 @@ def fetch(self): | |||
| 2. Yields the local path at which data has been replicated | |||
| 3. Performs any necessary cleanup | |||
| """ | |||
| raise NotImplemented() | |||
| raise NotImplementedError() | |||
There was a problem hiding this comment.
That's a nice catch of the tool
arthanson
approved these changes
Oct 10, 2024
|
Do we want to include a ruff.toml instead of passing the flags? Might be clearer / more flexible. |
bctiemann
pushed a commit
that referenced
this pull request
Oct 11, 2024
jeremystretch
added a commit
to alehaa/netbox
that referenced
this pull request
Oct 11, 2024
…box-community#17734) * Resolve F541 errors * Resolve F841 errors * Resolve F811 errors * Resolve F901 errors * Resolve E714 errors * Ignore F821 errors for GraphQL mixins * Replace pycodestyle with ruff * Move ignores to ruff.toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #17733
pycdoestylewithruffin the CI workflow and pre-commit script