Fixes: #17497 - Handle invalid accessor fields in bulk import forms #17594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e invalid accessor field
bctiemann
changed the title
jeremystretch
approved these changes
Sep 26, 2024
jeremystretch
deleted the
17497-handle-invalid-accessor-field-bulk-import
branch
bctiemann
added a commit
that referenced
this pull request
Oct 11, 2024
…17594) * Add handling for FieldError to CSVModelChoiceField.to_python to handle invalid accessor field * manufacturer & default_platform should be CSVModelChoiceFields * Fix string translation --------- Co-authored-by: Jeremy Stretch <jstretch@netboxlabs.com>
jeremystretch
added a commit
to alehaa/netbox
that referenced
this pull request
Oct 11, 2024
…k import forms (netbox-community#17594) * Add handling for FieldError to CSVModelChoiceField.to_python to handle invalid accessor field * manufacturer & default_platform should be CSVModelChoiceFields * Fix string translation --------- Co-authored-by: Jeremy Stretch <jstretch@netboxlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #17497
More generally solves the issue of invalid accessor field names in a
BulkImportFormby addingFieldErrorhandling to theto_pythonmethod ofCSVModelChoiceField.Note that this will only fix #17497 if #17593 is merged.