Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes: #17360 - Ensure model is defined when rendering bulk_edit_button #17535

Merged
merged 4 commits into from
Sep 26, 2024
Merged

Fixes: #17360 - Ensure model is defined when rendering bulk_edit_button #17535

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a6634a2
Ensure model is defined when rendering bulk_edit_button
bctiemann Sep 18, 2024
8940732
Move model check to inner conditional
bctiemann Sep 18, 2024
485d3ae
Set model in context
bctiemann Sep 19, 2024
c5966be
Return child_model instead of model for use in bulk_edit_button
bctiemann Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions netbox/netbox/views/generic/object_views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,10 +146,12 @@ def get(self, request, *args, **kwargs):
return render(request, 'htmx/table.html', {
'object': instance,
'table': table,
'model': self.child_model,
})

return render(request, self.get_template_name(), {
'object': instance,
'model': self.child_model,
'child_model': self.child_model,
'base_template': f'{instance._meta.app_label}/{instance._meta.model_name}.html',
'table': table,
Expand Down