Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #17051: Introduce the ISOLATED_DEPLOYMENT config parameter #17067

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

jeremystretch
Copy link
Member

Fixes: #17051

  • Introduce the ISOLATED_DEPLOYMENT config parameter
  • Disable the following functionality when True:
    • Automatic release checks (housekeeping task)
    • Census reporting
    • Plugins catalog integration
    • External footer links

@jeremystretch jeremystretch requested a review from arthanson August 1, 2024 19:50
@jeremystretch jeremystretch added this to the v4.1 milestone Aug 1, 2024
Copy link
Collaborator

@arthanson arthanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ISOLATED_NETWORK ?

@m2martin
Copy link
Contributor

m2martin commented Aug 2, 2024

I think it is worth to differentiate between the origin of requests. Some requests may originate from Netbox itself (e.g. release checks) which may fail due to isolation, others are originated from clients like the footer links which can be functional as the client is able to reach external ressources.

@jeremystretch
Copy link
Member Author

@m2martin yeah that's a good point. I'm going to revert the footer link changes as those are client-facing.

@jeremystretch jeremystretch merged commit 472fbdc into feature Aug 2, 2024
6 checks passed
@jeremystretch jeremystretch deleted the 17051-offline-config-param branch August 2, 2024 12:05
@trrunde
Copy link

trrunde commented Aug 23, 2024

what about the rss feed on the default frontpage? I just installed netbox on a labserver where I use proxy to reach internet, the domainname where not allowed, so rss feed timed out making the front page slow to load. If its an airgapped installation the rss feed widget should be removed.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants