Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #14740: Remove BootstrapMixin #14841

Merged
merged 8 commits into from
Jan 19, 2024
Merged

Closes #14740: Remove BootstrapMixin #14841

merged 8 commits into from
Jan 19, 2024

Conversation

jeremystretch
Copy link
Member

Closes: #14740

  • Introduces custom HTML templates for form widgets to handle the application of Bootstrap/Tabler CSS classes (e.g. form-control)
  • Removes the redundant application the required widget attribute for required form fields
  • Removes the application of the is-invalid CSS class for fields with errors & updates CSS to leverage the .has-errors class on the parent element
  • Completely removes the BootstrapMixin class
  • Removes now-obsolete child classes which existed only to inherit the mixin

@jeremystretch jeremystretch added this to the v4.0 milestone Jan 18, 2024
@jeremystretch jeremystretch merged commit da085e6 into feature Jan 19, 2024
6 checks passed
@jeremystretch jeremystretch deleted the 14740-remove-bootstrapmixin branch January 19, 2024 19:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arthanson arthanson Awaiting requested review from arthanson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.0
Development

Successfully merging this pull request may close these issues.
1 participant
@jeremystretch