Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

13845 fix device type image save #13851

Merged
merged 2 commits into from
Sep 25, 2023
Merged

13845 fix device type image save #13851

merged 2 commits into from
Sep 25, 2023

Conversation

arthanson
Copy link
Collaborator

@arthanson arthanson commented Sep 21, 2023 •
edited
Loading

Fixes: #13845

Tested locally and on S3, files are removed.

@arthanson arthanson changed the title DRAFT: 13845 fix device type image save 13845 fix device type image save Sep 21, 2023
@arthanson arthanson marked this pull request as ready for review September 25, 2023 14:26
jeremystretch
jeremystretch approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arthanson!

@jeremystretch jeremystretch merged commit 0ce2b1b into develop Sep 25, 2023
8 checks passed
@jeremystretch jeremystretch deleted the 13845-image-save branch September 25, 2023 17:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeremystretch jeremystretch jeremystretch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can not add image to device type
2 participants
@arthanson @jeremystretch