-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect Field Type in Response for GET /api/dcim/device-type(/{id}/) Model Schema #15184
Labels
severity: low
Does not significantly disrupt application functionality, or a workaround is available
status: accepted
This issue has been accepted for implementation
topic: OpenAPI
type: bug
A confirmed report of unexpected behavior in the application
Comments
Please specify exactly what you expect to see in the specification for the field. |
I would expect that the specification either say "nullable: true" or the response be an empty string for both fields. |
Can you point to an example of this elsewhere in the spec? |
abhi1693
added a commit
that referenced
this issue
Feb 20, 2024
abhi1693
added a commit
that referenced
this issue
Feb 20, 2024
jeremystretch
pushed a commit
that referenced
this issue
Feb 20, 2024
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
severity: low
Does not significantly disrupt application functionality, or a workaround is available
status: accepted
This issue has been accepted for implementation
topic: OpenAPI
type: bug
A confirmed report of unexpected behavior in the application
Deployment Type
Self-hosted
NetBox Version
v3.7.1
Python Version
3.11
Steps to Reproduce
Expected Behavior
I expected that the types in the response from the query would match what types are defined in the model.
Observed Behavior
We get back the wrong type in the response from the API when a front and/or rear image is not attached to a device_type.
![Screenshot from 2024-02-16 21-12-05](https://private-user-images.githubusercontent.com/141941931/305591480-05307258-aab8-4b30-9ce8-dca0c646668c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2NzIyOTUsIm5iZiI6MTczOTY3MTk5NSwicGF0aCI6Ii8xNDE5NDE5MzEvMzA1NTkxNDgwLTA1MzA3MjU4LWFhYjgtNGIzMC05Y2U4LWRjYTBjNjQ2NjY4Yy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNlQwMjEzMTVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1kOGE2ODBkNjNjN2U0ZWU0NjM0YzA4NzkzZGI4OTBiZjY4Yzg4ODFiZmU5YjA2ZThlZTQ3NjI4MWI3YmE0Y2E1JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.87E44X_yc8vOL3C3hUvi2vpHGgzJQO7dasnsgI1IPP8)
![Screenshot from 2024-02-16 21-11-55](https://private-user-images.githubusercontent.com/141941931/305591481-e460af63-4409-4b46-8af8-221d974d88dc.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2NzIyOTUsIm5iZiI6MTczOTY3MTk5NSwicGF0aCI6Ii8xNDE5NDE5MzEvMzA1NTkxNDgxLWU0NjBhZjYzLTQ0MDktNGI0Ni04YWY4LTIyMWQ5NzRkODhkYy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNlQwMjEzMTVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT00NzE4MDkzZDA1ZWM1MDZmYjc4YjA4ZTE3ZjJiNTdhMjU4MmU2OTA5NjhjYWI4NzRlN2YwOGVkYWYxNGYxMWM0JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.cX8JBf1hxnYWTP0N2fKP4YEszafOeoSOyTKXQjsYYb8)
The text was updated successfully, but these errors were encountered: