Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example custom script fails #15052

Closed
aharrisson opened this issue Feb 6, 2024 · 3 comments · Fixed by #15053
Closed

Example custom script fails #15052

aharrisson opened this issue Feb 6, 2024 · 3 comments · Fixed by #15053
Assignees
@jeffgdotorg
Labels
status: accepted This issue has been accepted for implementation type: documentation A change or addition to the documentation

Comments

@aharrisson
Copy link
Contributor

Change Type

Correction

Area

Customization

Proposed Changes

The example custom script fails since it creates Device objects with the old "role" field, rather than "device_role".
@aharrisson aharrisson added the type: documentation A change or addition to the documentation label Feb 6, 2024
aharrisson added a commit to aharrisson/netbox that referenced this issue Feb 6, 2024
@aharrisson
Fix custom script documentation example script
4afebd3 
The example script still uses the old "role" field when creating
a Device object.

Fixes netbox-community#15052
@aharrisson aharrisson mentioned this issue Feb 6, 2024
Merged
@jeffgdotorg jeffgdotorg self-assigned this Feb 9, 2024
@jeffgdotorg jeffgdotorg added the status: accepted This issue has been accepted for implementation label Feb 9, 2024
@jeffgdotorg
Copy link
Contributor

Good catch. Thanks for the issue and PR.

For future reference, our workflows require an accepted issue before a PR will be considered valid. For a one-line docs fix on a first issue, I'm going to let that go 😉

@aharrisson
Copy link
Contributor Author

Thank for the merge, @jeffgdotorg. 👍

Sorry. I did actually read the contribution rules, but it seemed like a lot of overhead for such a minor change. I will make sure to follow the correct process in the event of any future contributions.

@jeffgdotorg
Copy link
Contributor

Glad to do it, and glad to have you as a contributor!

Process wise there's a little bit of play in the gears for fixes as straightforward as this one. It matters more for changes with a broader scope.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeffgdotorg jeffgdotorg

Labels
status: accepted This issue has been accepted for implementation type: documentation A change or addition to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix custom script documentation example script aharrisson/netbox
2 participants
@jeffgdotorg @aharrisson