Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in Import form Field Options color #13839

Closed
sleepinggenius2 opened this issue Sep 20, 2023 · 3 comments · Fixed by #13857
Closed

Regression in Import form Field Options color #13839

sleepinggenius2 opened this issue Sep 20, 2023 · 3 comments · Fixed by #13857
Assignees
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation topic: UI/UX User interface or user experience related work type: bug A confirmed report of unexpected behavior in the application

Comments

@sleepinggenius2
Copy link
Contributor

NetBox version

v3.6.2

Python version

3.8

Steps to Reproduce

  1. Navigate to any Import form
  2. Observe the low contrast on the Field and Accessor columns of the Field Options table

Expected Behavior

The Field and Accessor columns of the Field Options table of an Import form should have sufficient contrast.

Observed Behavior

#13827 was introduced in v3.6.2 to fix #13653, but as a side effect, it changed the color of all <code> tags, which caused this regression.

@sleepinggenius2 sleepinggenius2 added the type: bug A confirmed report of unexpected behavior in the application label Sep 20, 2023
@arthanson arthanson assigned arthanson and unassigned arthanson Sep 20, 2023
@jeremystretch
Copy link
Member

It looks normal to me. Can you share a screenshot?

@sleepinggenius2
Copy link
Contributor Author

Before:
image

After:
image

@arthanson arthanson self-assigned this Sep 21, 2023
@jeremystretch
Copy link
Member

Ok, that's what I see too. So it's not that the text is unreadable, it just has less contrast than before in dark mode.

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation topic: UI/UX User interface or user experience related work severity: low Does not significantly disrupt application functionality, or a workaround is available labels Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation topic: UI/UX User interface or user experience related work type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants