Fixes: #13722 - Correct range expansion code when a numeric set is used

netbox-community · Feb 28, 2024 · 017a66b · 017a66b
1 parent edb7d24
commit 017a66b
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/netbox/utilities/forms/utils.py b/netbox/utilities/forms/utils.py
@@ -60,7 +60,7 @@ def parse_alphanumeric_range(string):
                 return []
         except ValueError:
             begin, end = dash_range, dash_range
-        if begin.isdigit() and end.isdigit():
+        if begin.isdigit() and end.isdigit() and not begin == end:
             if int(begin) >= int(end):
                 raise forms.ValidationError(_('Range "{value}" is invalid.').format(value=dash_range))
 

diff --git a/netbox/utilities/tests/test_forms.py b/netbox/utilities/tests/test_forms.py
@@ -191,7 +191,16 @@ def test_range_alpha(self):
 
         self.assertEqual(sorted(expand_alphanumeric_pattern(input)), output)
 
-    def test_set(self):
+    def test_set_numeric(self):
+        input = 'r[1,2]a'
+        output = sorted([
+            'r1a',
+            'r2a',
+        ])
+
+        self.assertEqual(sorted(expand_alphanumeric_pattern(input)), output)
+
+    def test_set_alpha(self):
         input = '[r,t]1a'
         output = sorted([
             'r1a',