Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When no build is needed don't create the buildx config #1309

Merged
merged 1 commit into from
Sep 6, 2024
Merged

When no build is needed don't create the buildx config #1309

merged 1 commit into from
Sep 6, 2024

Conversation

tobiasge
Copy link
Member

@tobiasge tobiasge commented Sep 6, 2024

Related Issue: -

New Behavior

  • Skips all steps when no build is needed

Contrast to Current Behavior

  • Try to create build which fails, because the login was skipped

Discussion: Benefits and Drawbacks

  • None

Changes to the Wiki

  • None

Proposed Release Note Entry

  • None

Double Check

  • I have read the comments and followed the PR template.
  • I have explained my PR according to the information in the comments.
  • My PR targets the develop branch.

@tobiasge tobiasge merged commit 656b118 into netbox-community:develop Sep 6, 2024
9 checks passed
@tobiasge tobiasge deleted the fix-step-skipping branch September 6, 2024 08:30
@tobiasge tobiasge mentioned this pull request Sep 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cimnine cimnine cimnine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobiasge @cimnine