profiles: anki: fix dark mode detection & misc changes #6581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amano-kenji
force-pushed
the
anki
branch
2 times, most recently
from
998cdde to
a71b501
Compare
kmk3
reviewed
Dec 29, 2024
amano-kenji
force-pushed
the
anki
branch
2 times, most recently
from
fe7e201 to
0a4cf17
Compare
kmk3
force-pushed
the
anki
branch
2 times, most recently
from
d20b522 to
325964a
Compare
kmk3
reviewed
Jan 6, 2025
| # anki uses mpv or mplayer for playing audio and uses lame to record audio. | ||
| # sh and dbus-send are used by aqt/theme.py to query dark mode through | ||
| # org.freedesktop.portal.Desktop. | ||
| private-bin anki,dbus-send,env,lame,lua*,mplayer,mpv,python*,sh |
There was a problem hiding this comment.
Is private-bin lua* actually needed?
mpv uses libluajit directly.
There was a problem hiding this comment.
I've been lazy. I will get back soon.
There was a problem hiding this comment.
I've been lazy. I will get back soon.
That's alright; it might be helpful to focus on one PR at a time.
I'd leave this and maybe 2 other PRs opened and close the rest if you don't
plan on working on them soon (and then they could gradually be reopened as the
open PRs are merged and as work is started on the closed ones).
This would also make reviews easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates: