Fix duplicate address detection (ARP) #6157
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is related to #6133 |
kmk3
changed the title
kmk3
reviewed
Jan 16, 2024
There was a problem hiding this comment.
Hello, the commit message body is currently empty; it does not contain any
explanation for what the commit does, which makes it unclear when viewing it
locally.
The current code compares the target IP of an ARP reply packet with the
srcaddr/sender IP of the request packet. Instead it should compare the
source IP of the ARP reply with the destaddr/target IP of the request
packet. In addition, this adds the check for ARP requests with the same
IP address in case other systems are probing for the same IP at the same
time as per the recommendation in RFC 5227.
This is related to #6133.
I formatted your original explanation above, can you add it to the commit
message body and force-push?
The current code compares the target IP of an ARP reply packet with the srcaddr/sender IP of the request packet. Instead it should compare the source IP of the ARP reply with the destaddr/target IP of the request packet. In addition, this adds the check for ARP requests with the same IP address in case other systems are probing for the same IP at the same time as per the recommendation in RFC 5227. This is related to netblue30#6133.
brianvanderburg2
force-pushed
the
master
branch
from
5885a85 to
35a8a53
Compare
|
Thanks, it looks good now. Note: I'm unfamiliar with the ARP code, so I'll avoid reviewing it for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code compare the target IP of an ARP reply packet with the srcaddr/sender IP of the request packet. Instead it should compare the source IP of the ARP reply with the destaddr/target IP of the request packet. In addition this adds the check for ARP requests with the same IP address in case other systems are probing for the same IP at the same time as per recommendation in RFC5227: