Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mgm close steps, in defer doing it already #729

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Conversation

pappz
Copy link
Contributor

@pappz pappz commented Mar 7, 2023

Describe your changes

Simple code cleaning. Remove duplicated steps in login.
In the defer already close the management connection.

Issue ticket number and link

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@pappz pappz requested review from braginini and gigovich March 7, 2023 09:38
@pappz pappz merged commit 24310c6 into main Mar 7, 2023
@pappz pappz deleted the login-break-up branch March 7, 2023 14:01
pappz added a commit that referenced this pull request Mar 7, 2023
Simple code cleaning. Remove duplicated steps in login.
In the defer already close the management connection.
pulsastrix pushed a commit to pulsastrix/netbird that referenced this pull request Dec 24, 2023
Simple code cleaning. Remove duplicated steps in login.
In the defer already close the management connection.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants