Allow to create config file next to binary #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlsmaycon
reviewed
Feb 22, 2023
If we do not define the configDir then the Go create a random temp dir for copy routine. It is not optimal from security purpose.
mlsmaycon
approved these changes
Feb 27, 2023
pulsastrix
pushed a commit
to pulsastrix/netbird
that referenced
this pull request
Dec 24, 2023
Force to use the proper temp dir If we do not define the configDir then the Go create a random temp dir for copy routine. It is not optimal from security purpose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Without you set the full path of the config file the Netbird can not
handle it. We check the path of the given config file's name and
if it is not contain a folder then skip the step to create a folder
for it.
You can place the config file next to the binary:
./netbird up --config myconfig.json
Issue ticket number and link
Checklist