New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reformat IPv6 ICE addresses when hole punching #3050

Merged

mlsmaycon merged 1 commit into netbirdio:main from jclds139:main

Dec 16, 2024

Contributor

jclds139 commented Dec 13, 2024

Describe your changes

Check for IPv6 addresses during hole punching, adding brackets around them as needed

Issue ticket number and link

#2327 and #2606

Checklist

Is it a bug fix
Is a typo/documentation fix
Is a feature enhancement
It is a refactor
Created tests that fail without the change (if possible)
Extended the README / documentation, if necessary


          fix: reformat IPv6 ICE addresses when punching

26907a8

Should fix netbirdio#2327 and netbirdio#2606 by checking for IPv6 addresses from ICE

CLAassistant commented Dec 13, 2024 •

edited

Loading

All committers have signed the CLA.

sonarqubecloud bot commented Dec 13, 2024

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

mlsmaycon approved these changes

View reviewed changes

Collaborator

mlsmaycon left a comment

thanks for the contribution @jclds139

mlsmaycon merged commit 3844516 into netbirdio:main

26 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet