[client] Fix state manager race conditions #2890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pappz
reviewed
Nov 14, 2024
| start := time.Now() | ||
| go func() { | ||
| done <- util.WriteJsonWithRestrictedPermission(ctx, m.filePath, m.states) | ||
| done <- util.WriteBytesWithRestrictedPermission(ctx, m.filePath, bs) |
There was a problem hiding this comment.
What will be if this function running more then 10 sec? The ticker will start a PersistState call and will be a conflict in the file.
There was a problem hiding this comment.
That's what the ctx check and deadline is for in this fn
There was a problem hiding this comment.
But the check and move is not an atomic operation. If the code runs parallel this lines with two different ctx the outcome is unpredictable.
// Check context again
if ctx.Err() != nil {
return ctx.Err()
}
if err = os.Rename(tempFileName, file); err != nil {
return fmt.Errorf("move %s to %s: %w", tempFileName, file, err)
}
```
lixmal
force-pushed
the
fix-state-races
branch
from
9f68e34 to
c8ec1bc
Compare
|
pappz
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Checklist