Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[management] Remove context from database calls #2863

Merged
merged 2 commits into from
Nov 8, 2024
Merged

[management] Remove context from database calls #2863

merged 2 commits into from
Nov 8, 2024

Conversation

pascal-fischer
Copy link
Contributor

Describe your changes

Issue ticket number and link

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

bcmmbaga
bcmmbaga requested changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@bcmmbaga bcmmbaga left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're no longer passing context into db calls, the context cancellation check is not needed anymore. GORM won’t report context cancellation without the context, so it's better to remove these checks

management/server/sql_store.go Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@pascal-fischer pascal-fischer merged commit 669904c into main Nov 8, 2024
21 checks passed
@pascal-fischer pascal-fischer deleted the fix/remove-context-from-db branch November 8, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcmmbaga bcmmbaga bcmmbaga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pascal-fischer @bcmmbaga