[management] Refactor setup key to use store methods #2861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
bcmmbaga
force-pushed
the
setupkey-get-account-refactoring
branch
from
997f1e1 to
1a5f3c6
Compare
Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
bcmmbaga
force-pushed
the
setupkey-get-account-refactoring
branch
from
7190ea1 to
931521d
Compare
Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
…unt-refactoring # Conflicts: # management/server/sql_store.go
bcmmbaga
changed the base branch from
feature/get-account-refactoring
to
main
Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
pascal-fischer
requested changes
Nov 11, 2024
Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
…lice Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
bcmmbaga
force-pushed
the
setupkey-get-account-refactoring
branch
from
f443d47 to
cf2766d
Compare
|
pascal-fischer
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Remove calls to get and save whole account in setup key operations.
Issue ticket number and link
Checklist