Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid token on peer login due to the cache race #1763

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

braginini
Copy link
Contributor

Describe your changes

The issue happens when a new account is created not through the dashboard but by logging in a new machine.

The fix just does 3 retries with a delay on token validation.

Issue ticket number and link

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@braginini braginini merged commit 22beac1 into main Mar 28, 2024
16 checks passed
@braginini braginini deleted the fix/peer_login_idp_cache branch March 28, 2024 11:33
Foosec pushed a commit to Foosec/netbird that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants