Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unblock ACL apply filtering because of dns probes #1711

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

mlsmaycon
Copy link
Collaborator

Describe your changes

moved the e.dnsServer.ProbeAvailability() to run after ACL apply filtering

run the probes in parallel

Issue ticket number and link

fixes #1704

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

moved the e.dnsServer.ProbeAvailability() to run after ACL apply filtering

run the probes in parallel
@mlsmaycon mlsmaycon marked this pull request as ready for review March 15, 2024 17:57
@mlsmaycon mlsmaycon merged commit 416f04c into main Mar 15, 2024
16 checks passed
@mlsmaycon mlsmaycon deleted the unblock-acl-apply-filter branch March 15, 2024 17:57
Foosec pushed a commit to Foosec/netbird that referenced this pull request May 8, 2024
moved the e.dnsServer.ProbeAvailability() to run after ACL apply filtering

run the probes in parallel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Probing upstream nameserver timeout
2 participants