Send UI notification on peer session expiry #1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stem for session expiration.
This update introduces a new SessionWatcher in the internal package of the client UI. The purpose of SessionWatcher is to periodically check the login status, and in case the session expires, it triggers a predefined onExpireListener function. An appropriate listener can be set to notify the user about session expiration.
|
@braginini, I've updated the text |
NetBird is redundant. It is in the title (and it has to be NetBird not Netbird). |
|
Can we also send a similar notification before the expiration? Like 15 minutes before? |
It will be part of another improvement in the future. For that, we need to update the management protocol and learn information about expiration settings from the account. |
mlsmaycon
previously approved these changes
Mar 1, 2024
mlsmaycon
approved these changes
Mar 1, 2024
Foosec
pushed a commit
to Foosec/netbird
that referenced
this pull request
May 8, 2024
notify the user when the peer connection session expires after it switches from connected to disconnected and the status is login required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Windows
Linux
MacOS
Issue ticket number and link
Checklist