FIx order when validating account settings #1632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlsmaycon
approved these changes
Feb 27, 2024
pascal-fischer
deleted the
fix/order-when-validating-account-settings
branch
Foosec
pushed a commit
to Foosec/netbird
that referenced
this pull request
May 8, 2024
* moved extraSettings validation to the end * moved extraSettings validation directly after permission check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The settings validation was moved behind the user permission check to avoid unnecessary validation in case the user is not allowed to update the settings anyway.
Issue ticket number and link
Checklist