Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid creating duplicate groups with the same name #1579

Merged
merged 15 commits into from
Mar 17, 2024
Merged

Avoid creating duplicate groups with the same name #1579

merged 15 commits into from
Mar 17, 2024

Conversation

braginini
Copy link
Contributor

Describe your changes

Issue ticket number and link

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

surik
surik reviewed Feb 13, 2024
View reviewed changes
management/server/group.go Outdated Show resolved Hide resolved
surik
surik reviewed Feb 13, 2024
View reviewed changes
management/server/group.go Outdated Show resolved Hide resolved
@braginini @surik
fix typo
5115543 
Co-authored-by: Yury Gargay <yury.gargay@gmail.com>
mlsmaycon
mlsmaycon previously approved these changes Mar 15, 2024
View reviewed changes
@mlsmaycon mlsmaycon self-requested a review March 15, 2024 17:20
@mlsmaycon mlsmaycon merged commit abd57d1 into main Mar 17, 2024
16 checks passed
@mlsmaycon mlsmaycon deleted the fix/avoid_duplicate_groups branch March 17, 2024 10:13
Foosec pushed a commit to Foosec/netbird that referenced this pull request May 8, 2024
@braginini
Avoid creating duplicate groups with the same name (netbirdio#1579)
0417380 
Avoid creating groups with the same name via API calls. 

JWT and integrations still allowed to register groups with duplicated names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascal-fischer pascal-fischer pascal-fischer left review comments

@surik surik surik left review comments

@mlsmaycon mlsmaycon mlsmaycon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@braginini @surik @mlsmaycon @pascal-fischer