Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated Rules API endpoints #1523

Merged
merged 3 commits into from
Mar 14, 2024
Merged

Remove deprecated Rules API endpoints #1523

merged 3 commits into from
Mar 14, 2024

Conversation

surik
Copy link
Contributor

@surik surik commented Feb 2, 2024 •
edited
Loading

Describe your changes

This PR removes the deprecated rules endpoint and all usage of Account.Rules in the management.

Issue ticket number and link

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@surik
Copy link
Contributor Author

surik commented Feb 5, 2024

I keep this one as a draft as we may want to do it in 2 steps.
The first step is to remove usage of Rules in store engines: #1528
Later we can rebase the current one and merge it to remove the endpoints completely.

@surik surik changed the title Remove Account.Rules from Store engines Remove Account.Rules from Store engines and related endpoints Feb 5, 2024
@surik surik changed the title Remove Account.Rules from Store engines and related endpoints Remove deprecated Rules API endpoints Feb 19, 2024
@surik surik force-pushed the yury/remove-rules branch from 54acf6e to 92d6be6 Compare February 19, 2024 16:28
@surik surik force-pushed the yury/remove-rules branch from ff09490 to 82b964b Compare March 4, 2024 13:42
@surik surik marked this pull request as ready for review March 4, 2024 14:04
@surik surik requested a review from mlsmaycon March 4, 2024 14:04
@mlsmaycon mlsmaycon merged commit 0b3b50c into main Mar 14, 2024
16 checks passed
@mlsmaycon mlsmaycon deleted the yury/remove-rules branch March 14, 2024 20:31
Foosec pushed a commit to Foosec/netbird that referenced this pull request May 8, 2024
@surik
Remove deprecated Rules API endpoints (netbirdio#1523)
542c31d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlsmaycon mlsmaycon mlsmaycon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@surik @mlsmaycon