Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IPv6 format for DNS address received from android #1350

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Fix IPv6 format for DNS address received from android #1350

merged 2 commits into from
Dec 1, 2023

Conversation

mlsmaycon
Copy link
Collaborator

Describe your changes

this adds the address in the expected format in Go [ipv6]:port

Issue ticket number and link

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@mlsmaycon
Fix IPv6 format for DNS address received from android
533c587 
this adds the address in the expected format in Go [ipv6]:port
@mlsmaycon mlsmaycon requested a review from pappz December 1, 2023 12:35
@mlsmaycon mlsmaycon marked this pull request as ready for review December 1, 2023 12:35
surik
surik reviewed Dec 1, 2023
View reviewed changes
client/internal/dns/server.go Outdated Show resolved Hide resolved
pappz
pappz requested changes Dec 1, 2023
View reviewed changes
client/internal/dns/server.go Outdated Show resolved Hide resolved
client/internal/dns/server.go Show resolved Hide resolved
@mlsmaycon mlsmaycon requested review from pappz and surik December 1, 2023 13:01
@mlsmaycon mlsmaycon merged commit b8c46e2 into main Dec 1, 2023
15 checks passed
@mlsmaycon mlsmaycon deleted the fix/format-ipv6-dns-addresses branch December 1, 2023 13:26
surik pushed a commit that referenced this pull request Dec 14, 2023
@mlsmaycon @surik
Fix IPv6 format for DNS address received from android (#1350)
fd42a34 
this adds the address in the expected format in Go [ipv6]:port
pulsastrix pushed a commit to pulsastrix/netbird that referenced this pull request Dec 24, 2023
@mlsmaycon
Fix IPv6 format for DNS address received from android (netbirdio#1350)
208c444 
this adds the address in the expected format in Go [ipv6]:port
Foosec pushed a commit to Foosec/netbird that referenced this pull request May 8, 2024
@mlsmaycon
Fix IPv6 format for DNS address received from android (netbirdio#1350)
73dee54 
this adds the address in the expected format in Go [ipv6]:port
@WolfgangDpunkt
Copy link

this adds the address in the expected format in Go [ipv6]:port

I think this would also have to be adapted for the Linux client.
Every ipv6 DNS address that I enter via the Management Gui results in this error message on a debian server client:

dial udp: address 2001:4860:4860::8888:53: too many colons in address

@WolfgangDpunkt WolfgangDpunkt mentioned this pull request Jul 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pappz pappz pappz approved these changes

@surik surik surik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mlsmaycon @WolfgangDpunkt @surik @pappz