Support pinning version during binary install #1237
Conversation
|
|
|
Hello @glemsom, thanks for your contribution. Please check the annotations from Codacy regarding double quotes and we should be good to go. |
As per Maycon's suggestion
release_files/install.sh
Outdated
| @@ -23,19 +23,28 @@ if command -v sudo > /dev/null && [ "$(id -u)" -ne 0 ]; then | |||
| SUDO="sudo" | |||
| fi | |||
|
|
|||
| get_latest_release() { | |||
| if [ -z ${NETBIRD_RELEASE+x} ]; then | |||
There was a problem hiding this comment.
This seems to be failing. Can you try the following?
| if [ -z ${NETBIRD_RELEASE+x} ]; then | |
| if [ "x-$NETBIRD_RELEASE" = "x-" ]; then |
release_files/install.sh
Outdated
|
|
||
| get_release() { | ||
| local RELEASE=$1 | ||
| if [ "$RELEASE" == "latest" ]; then |
There was a problem hiding this comment.
| if [ "$RELEASE" == "latest" ]; then | |
| if [ "$RELEASE" = "latest" ]; then |
There was a problem hiding this comment.
Sorry for the late reply.
You're right. I only tested my change with bash.
I read through the workflows, and see we test using ubuntu:latest, which default to dash as shell - which in return does not support the "double equal-sign" that bash does.
Sorry about that !
(I've now imported your validation actions to my fork) 😄
We should for sure keep the validation action as-is, as it mimic the current recommended one-line installation behavior on the website. (I should just have tested my change better!)
This is now corrected to be POSIX compatible. (efc8164)
I imported the validation workflows to my fork - seems to go through now :)
|
@glemsom |
|
You are welcome. And thanks for an awesome product :) |
For installations using the binary release method (using the official installer script), it would be nice to be able to define a specific version to install. A user/developer can choose to define the NETBIRD_RELEASE variable during installation, to pin a specific version during installation. If NETBIRD_RELEASE is not defined, we default to the current behavior of latest
For installations using the binary release method (using the official installer script), it would be nice to be able to define a specific version to install. A user/developer can choose to define the NETBIRD_RELEASE variable during installation, to pin a specific version during installation. If NETBIRD_RELEASE is not defined, we default to the current behavior of latest
Support for specific version installation
For installations using the binary release method (using the official installer script), it would be nice to be able to define a specific version to install.
A user/developer can choose to define the
NETBIRD_RELEASEvariable during installation, to pin a specific version during installation.If
NETBIRD_RELEASEis not defined, we default to the current behavior oflatestExample usage (once merged)
Checklist