Properly handle cache error and return userdata (#1571)

netbirdio · Feb 12, 2024 · dd14db6 · dd14db6
1 parent 88747e3
commit dd14db6
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/management/server/account.go b/management/server/account.go
@@ -1231,14 +1231,12 @@ func (am *DefaultAccountManager) lookupUserInCache(userID string, account *Accou
 
 	key := user.IntegrationReference.CacheKey(account.Id, userID)
 	ud, err := am.externalCacheManager.Get(am.ctx, key)
-	if err == nil {
+	if err != nil {
 		log.Errorf("failed to get externalCache for key: %s, error: %s", key, err)
-		return ud, status.Errorf(status.NotFound, "user %s not found in the IdP", userID)
+		return nil, status.Errorf(status.NotFound, "user %s not found in the IdP", userID)
 	}
 
-	log.Infof("user %s not found in any cache", userID)
-
-	return nil, nil //nolint:nilnil
+	return ud, nil
 }
 
 func (am *DefaultAccountManager) refreshCache(accountID string) ([]*idp.UserData, error) {