Skip to content

Commit

Permalink
getFirstListenerAvailable(): adjust logging levels and add success me…
Browse files Browse the repository at this point in the history
…ssage (#1513)

it was worrying to see multiple warnings and no success message when lacking CAP_NET_BIND_SERVICE
  • Loading branch information
nazarewk authored Jan 31, 2024
1 parent 846d486 commit b6835d9
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions client/internal/dns/service_listener.go
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ func (s *serviceViaListener) setListenerStatus(running bool) {
s.listenerIsRunning = running
}

func (s *serviceViaListener) getFirstListenerAvailable() (string, int, error) {
func (s *serviceViaListener) getFirstDNSListenerAvailable() (string, int, error) {
ips := []string{defaultIP, customIP}
if runtime.GOOS != "darwin" {
ips = append([]string{s.wgInterface.Address().IP.String()}, ips...)
Expand All @@ -156,9 +156,10 @@ func (s *serviceViaListener) getFirstListenerAvailable() (string, int, error) {
if err != nil {
log.Errorf("got an error closing the probe listener, error: %s", err)
}
log.Infof("successfully found dns binding candidate at %s", addrString)
return ip, port, nil
}
log.Warnf("binding dns on %s is not available, error: %s", addrString, err)
log.Debugf("binding dns on %s is not available, error: %s", addrString, err)
}
}
return "", 0, fmt.Errorf("unable to find an unused ip and port combination. IPs tested: %v and ports %v", ips, ports)
Expand All @@ -169,7 +170,7 @@ func (s *serviceViaListener) evalListenAddress() (string, int, error) {
return s.customAddr.Addr().String(), int(s.customAddr.Port()), nil
}

return s.getFirstListenerAvailable()
return s.getFirstDNSListenerAvailable()
}

// shouldApplyPortFwd decides whether to apply eBPF program to capture DNS traffic on port 53.
Expand Down

0 comments on commit b6835d9

Please sign in to comment.