Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Add tslib and use importHelpers in tsconfig.base.json #3748

Merged
merged 1 commit into from
Jan 24, 2020
Merged

Conversation

Boshen
Copy link
Contributor

@Boshen Boshen commented Jan 5, 2020

closes #3740

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[*] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[*] No

Other information

@Boshen
Copy link
Contributor Author

Boshen commented Jan 5, 2020

977,455 bytes -> 961,182 bytes 1.66% reduction

@coveralls
Copy link

coveralls commented Jan 5, 2020

Pull Request Test Coverage Report for Build 11551

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.436%

Totals Coverage Status
Change from base Build 11535: 0.0%
Covered Lines: 4475
Relevant Lines: 4689

💛 - Coveralls

@kamilmysliwiec
Copy link
Member

kamilmysliwiec commented Jan 8, 2020

What about individual package.json files (example https://github.com/nestjs/nest/blob/master/packages/common/package.json)? We should add tslib there as well.

@Boshen
Copy link
Contributor Author

Boshen commented Jan 9, 2020

@kamilmysliwiec Done. There seems to be an extra packages/common/package-lock.json file, I've removed it in this PR, it was introduced in commit 1f83167

@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tslib as helper
3 participants