-
-
Notifications
You must be signed in to change notification settings - Fork 7.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/grpc multipackage #3097
Conversation
before: grpcOptions: <GrpcOptions>{ transport: Transport.GRPC, options: { url: 'url', package: 'name.package', protoPath: 'alone.proto' } } after: grpcOptions: <GrpcOptions>{ transport: Transport.GRPC, options: { url: 'url', package: ['name.package', 'other.package'], protoPath: [ 'one.proto', 'two.proto', 'any.proto' ] } }
…nfig before: grpcOptions: <GrpcOptions>{ transport: Transport.GRPC, options: { url: 'url', package: 'name.package', protoPath: 'alone.proto' } } after: grpcOptions: <GrpcOptions>{ transport: Transport.GRPC, options: { url: 'url', package: ['name.package', 'other.package'], protoPath: [ 'one.proto', 'two.proto', 'any.proto' ] } }
# Conflicts: # integration/microservices/src/grpc/grpc.controller.ts # packages/microservices/client/client-grpc.ts # packages/microservices/server/server-grpc.ts
Pull Request Test Coverage Report for Build 3622
💛 - Coveralls |
packages/microservices/test/client/client-grpc-multi-packages.spec.ts
Outdated
Show resolved
Hide resolved
Could you add support for globbing using e.g https://github.com/micromatch/micromatch? If it's out of the scope, I'll just create a PR after this is merged. Since you can't define protos to load at module level, then this would be a handy feature. |
It's out of the scope but you can add issue and we discuss this |
5ad1559
to
8dffee8
Compare
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
before:
after:
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Added use packages and protos from external libraries ang default grpc functionality also https://github.com/grpc/grpc/blob/master/src/proto/grpc/health/v1/health.proto
Does this PR introduce a breaking change?
Other information
Discussion #1733 (comment)