Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common)!: drop broken support for promises on exports of modules #14114

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

micalevisk
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: closes #13733

What is the new behavior?

we don't support supplying promises to the exports option of @Module()/dynamic module anymore. This feature never worked, anyway.

Does this PR introduce a breaking change?

  • Yes
  • No

@micalevisk micalevisk changed the title fix(common): drop broken support for promises on exports of modules fix(common)!: drop broken support for promises on exports of modules Nov 7, 2024
@micalevisk micalevisk added this to the 11.0.0 milestone Nov 7, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build d2645ff2-1080-442a-91ba-c314def39343

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.243%

Totals Coverage Status
Change from base Build 72f148bc-4145-44b3-a3c4-06a616307114: 0.0%
Covered Lines: 6754
Relevant Lines: 7322

💛 - Coveralls

@kamilmysliwiec kamilmysliwiec changed the base branch from master to 11.0.0 November 7, 2024 13:10
@kamilmysliwiec kamilmysliwiec merged commit 3081f54 into nestjs:11.0.0 Nov 7, 2024
5 checks passed
@micalevisk micalevisk deleted the fix-issue-13733 branch November 7, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic module promises in the exports array is broken
3 participants