Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(platform-fastify): search method not declared #13807

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

johaven
Copy link
Contributor

@johaven johaven commented Jul 21, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

The usage of the @Search method with fastify was not properly declared

node_modules/@nestjs/core/adapters/http-adapter.js:59
        return this.instance.search(...args);
                             ^

TypeError: this.instance.search is not a function
    at FastifyAdapter.search (node_modules/@nestjs/core/adapters/http-adapter.js:59:30)
    at node_modules/@nestjs/core/router/router-explorer.js:105:17
    at Array.forEach (<anonymous>)
    at node_modules/@nestjs/core/router/router-explorer.js:90:29
    at Array.forEach (<anonymous>)
    at RouterExplorer.applyCallbackToRouter (node_modules/@nestjs/core/router/router-explorer.js:82:15)
    at node_modules/@nestjs/core/router/router-explorer.js:65:18
    at Array.forEach (<anonymous>)
    at RouterExplorer.applyPathsToRouterProxy (node_modules/@nestjs/core/router/router-explorer.js:62:34)
    at RouterExplorer.explore (node_modules/@nestjs/core/router/router-explorer.js:49:14)

Does this PR introduce a breaking change?

  • No

@coveralls
Copy link

Pull Request Test Coverage Report for Build cd5e366f-0c3a-4138-b054-2cb3cbc4a324

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.208%

Totals Coverage Status
Change from base Build 7ea6f01d-9fcc-4d6c-90b4-f217d2306325: 0.0%
Covered Lines: 6745
Relevant Lines: 7315

💛 - Coveralls

@kamilmysliwiec kamilmysliwiec merged commit 0048313 into nestjs:master Aug 12, 2024
5 checks passed
@kamilmysliwiec
Copy link
Member

lgtm

@johaven johaven deleted the fix-search-method branch August 12, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants