fix(fastify-adapter): middleware not executed when root path is excluded #13797
+143
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #13401 , #11572
By using
FastifyAdapter
and setting a route config withexclude
andprefix
the middleware stops begin executedFor reproduction see tests in https://github.com/xtrinch/nestjs-middleware-issue-demo provided by @xtrinch
The behavior occurs because during the normalization performed on the pathname, it is not taken into account whether the application instance was configured to handle a prefix.
What is the new behavior?
These changes guarantee that when the Adapter is registered with a prefix, the normalization of the pathname will be taken into account when generating the regex expression.
Does this PR introduce a breaking change?
Other information
Note: Given the @fastify/middie behavior described in docs the middleware will receive
raw
request and response objects, but controller will receive the wrapper object. With this in mind, to access this objects modified in middleware in controller instances, needs to access theraw
object, otherwise, the wrapper will note have the changes executed by middleware.