Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): allow importing providers from global modules in lazy modules #12035

Merged
merged 3 commits into from
Jul 17, 2023

Conversation

kamilmysliwiec
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Fork of #10005

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8d4560fa-fe80-4ce7-a8b1-97beabe15495

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 92.813%

Totals Coverage Status
Change from base Build 0a9eba70-11bd-4863-a9a0-ef9f98d64f51: 0.003%
Covered Lines: 6392
Relevant Lines: 6887

💛 - Coveralls

@kamilmysliwiec kamilmysliwiec merged commit 33b0aaa into master Jul 17, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix/globals-in-lazy-modules branch July 17, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants